linux-kernel - Re: [PATCH] scsi:libiscsi:Fix an error count for active session

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Mar 2020 10:35:13 -0700
From:   Lee Duncan <lduncan@...e.com>
To:     "wubo (T)" <wubo40@...wei.com>, Chris Leech <cleech@...hat.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "open-iscsi@...glegroups.com" <open-iscsi@...glegroups.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     linfeilong <linfeilong@...wei.com>,
        "liuzhiqiang (I)" <liuzhiqiang26@...wei.com>
Subject: Re: [PATCH] scsi:libiscsi:Fix an error count for active session

On 3/24/20 11:53 PM, wubo (T) wrote:
> From: Wu Bo <wubo40@...wei.com>
> 
> Fix an error count for active session if the total_cmds is invalid 
> on the function iscsi_session_setup().
> decrement the number of active sessions before the func return.
> 
> Signed-off-by: Wu Bo <wubo40@...wei.com>
> ---
>  drivers/scsi/libiscsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 70b99c0..b7158eb 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -2771,7 +2771,7 @@ struct iscsi_cls_session *
>                        "must be a power of 2.\n", total_cmds);
>                 total_cmds = rounddown_pow_of_two(total_cmds);
>                 if (total_cmds < ISCSI_TOTAL_CMDS_MIN)
> -                       return NULL;
> +                       goto dec_session_count;
>                 printk(KERN_INFO "iscsi: Rounding can_queue to %d.\n",
>                        total_cmds);
>         }
> --
> 1.8.3.1
> 

Reviewed-by: Lee Duncan <lduncan@...se.com>