linux-kernel - RE: [PATCH v2 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYAPR01MB454433CC3EEC24AF8619526FD8CC0@TYAPR01MB4544.jpnprd01.prod.outlook.com>
Date:   Fri, 27 Mar 2020 02:42:03 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Kishon Vijay Abraham I <kishon@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v2 1/4] dt-bindings: phy: renesas: usb2-phy: convert
 bindings to json-schema

Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Thursday, March 26, 2020 6:00 PM
<snip>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > @@ -0,0 +1,103 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> 
> I think Rob would prefer to see
> 
>     # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

I'll fix it.

> > +  reg:
> > +    # base address and length of the registers block for the PHY.
> 
> The comment is not needed.

OK. I'll remove it.

> > +    maxItems: 1
> > +
> > +  clocks:
> > +    # clock phandle and specifier pair(s).
> 
> Likewise.

I got it.

> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  clock-names:
> > +    # for RZ/A2
> 
> if:
>   properties:
>     compatible:
>       items:
>         enum:
>           - renesas,usb2-phy-r7s9210

Thank you for the proposal. I'll fix it.

> > +    minItems: 1
> > +    maxItems: 2
> > +    items:
> > +      - const: fck
> > +      - const: usb_x1
> 
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/r8a7795-cpg-mssr.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/power/r8a7795-sysc.h>
> > +
> > +    usb-phy@...80200 {
> > +        compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> > +        reg = <0 0xee080200 0 0x700>;
> 
> Examples are built with #{address,size}-cells = <1>, so
> 
>     reg = <0xee080200 0x700>;

I got it. I'll fix it.

> > +        interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> > +        clocks = <&cpg CPG_MOD 703>;
> > +        #phy-cells = <1>;
> > +    };
> > +
> > +    usb-phy@...a0200 {
> > +        compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> > +        reg = <0 0xee0a0200 0 0x700>;
> 
> reg = <0xee0a0200 0x700>;

Yes, I'll fix it.

Best regards,
Yoshihiro Shimoda