linux-kernel - Re: [PATCH 1/2] remoteproc: Add userspace char device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202003271109.zHMSxsbu%lkp@intel.com>
Date:   Fri, 27 Mar 2020 12:00:04 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rishabh Bhatnagar <rishabhb@...eaurora.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, bjorn.andersson@...aro.org,
        ohad@...ery.com
Subject: Re: [PATCH 1/2] remoteproc: Add userspace char device driver

Hi Rishabh,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on linux/master v5.6-rc7]
[cannot apply to next-20200326]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rishabh-Bhatnagar/Add-character-device-interface-to-remoteproc/20200327-062958
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9420e8ade4353a6710908ffafa23ecaf1caa0123
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/remoteproc/remoteproc_userspace.c:31:12: error: conflicting types for 'rproc_release'
      31 | static int rproc_release(struct inode *inode, struct file *file)
         |            ^~~~~~~~~~~~~
   In file included from drivers/remoteproc/remoteproc_userspace.c:14:
   drivers/remoteproc/remoteproc_internal.h:28:6: note: previous declaration of 'rproc_release' was here
      28 | void rproc_release(struct kref *kref);
         |      ^~~~~~~~~~~~~

vim +/rproc_release +31 drivers/remoteproc/remoteproc_userspace.c

    30	
  > 31	static int rproc_release(struct inode *inode, struct file *file)
    32	{
    33		struct rproc *rproc;
    34	
    35		rproc = container_of(inode->i_cdev, struct rproc, char_dev);
    36		if (!rproc)
    37			return -EINVAL;
    38	
    39		rproc_shutdown(rproc);
    40	
    41		return 0;
    42	}
    43	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (52754 bytes)