linux-kernel - Re: [PATCH net-next 02/12] ethtool: provide coalescing parameters with COALESCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326211605.6f80f9c7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 26 Mar 2020 21:16:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 02/12] ethtool: provide coalescing parameters
 with COALESCE_GET request

On Fri, 27 Mar 2020 01:11:57 +0100 (CET) Michal Kubecek wrote:
> Implement COALESCE_GET request to get coalescing parameters of a network
> device. These are traditionally available via ETHTOOL_GCOALESCE ioctl
> request. This commit adds only support for device coalescing parameters,
> not per queue coalescing parameters.
> 
> Omit attributes with zero values unless they are declared as supported
> (i.e. the corresponding bit in ethtool_ops::supported_coalesce_params is
> set).
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>