linux-kernel - Re: [PATCH v2] ipv4: fix a RCU-list lock in fib_triestat_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <707e70a3-59f7-bc11-fd11-c5409e39c476@gmail.com>
Date:   Thu, 26 Mar 2020 22:41:40 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, cai@....pw
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, kuba@...nel.org,
        eric.dumazet@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ipv4: fix a RCU-list lock in fib_triestat_seq_show



On 3/26/20 8:27 PM, David Miller wrote:
> From: Qian Cai <cai@....pw>
> Date: Wed, 25 Mar 2020 18:01:00 -0400

>> Fix it by adding a pair of rcu_read_lock/unlock() and use
>> cond_resched_rcu() to avoid the situation where walking of a large
>> number of items  may prevent scheduling for a long time.
>>
>> Signed-off-by: Qian Cai <cai@....pw>
> 
> Eric, please review.
> 

Patch looks good to me, thanks !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>