| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Mar 2020 09:32:27 +0100
From: saravanan sekar <sravanhome@...il.com>
To: Lee Jones <lee.jones@...aro.org>
Cc: robh+dt@...nel.org, jic23@...nel.org, knaack.h@....de,
lars@...afoo.de, pmeerw@...erw.net, sre@...nel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-iio@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger
Hi Lee,
On 27/03/20 8:55 am, Lee Jones wrote:
> On Sun, 22 Mar 2020, Saravanan Sekar wrote:
>
>> mp2629 is a highly-integrated switching-mode battery charge management
>> device for single-cell Li-ion or Li-polymer battery.
>>
>> Add MFD core enables chip access for ADC driver for battery readings,
>> and a power supply battery-charger driver
>>
>> Signed-off-by: Saravanan Sekar <sravanhome@...il.com>
>> ---
>> drivers/mfd/Kconfig | 9 +++
>> drivers/mfd/Makefile | 2 +
>> drivers/mfd/mp2629.c | 116 +++++++++++++++++++++++++++++++++++++
>> include/linux/mfd/mp2629.h | 22 +++++++
>> 4 files changed, 149 insertions(+)
>> create mode 100644 drivers/mfd/mp2629.c
>> create mode 100644 include/linux/mfd/mp2629.h
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 3c547ed575e6..6614e5cff881 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -434,6 +434,15 @@ config MFD_MC13XXX_I2C
>> help
>> Select this if your MC13xxx is connected via an I2C bus.
>>
>> +config MFD_MP2629
>> + bool "Monolithic power system MP2629 ADC and Battery charger"
>> + depends on I2C
>> + select REGMAP_I2C
>> + help
>> + Select this option to enable support for monolithic power system
>> + battery charger. This provides ADC, thermal, battery charger power
>> + management functions on the systems.
>> +
>> config MFD_MXS_LRADC
>> tristate "Freescale i.MX23/i.MX28 LRADC"
>> depends on ARCH_MXS || COMPILE_TEST
>> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
>> index f935d10cbf0f..d6c210f96d02 100644
>> --- a/drivers/mfd/Makefile
>> +++ b/drivers/mfd/Makefile
>> @@ -170,6 +170,8 @@ obj-$(CONFIG_MFD_MAX8925) += max8925.o
>> obj-$(CONFIG_MFD_MAX8997) += max8997.o max8997-irq.o
>> obj-$(CONFIG_MFD_MAX8998) += max8998.o max8998-irq.o
>>
>> +obj-$(CONFIG_MFD_MP2629) += mp2629.o
>> +
>> pcf50633-objs := pcf50633-core.o pcf50633-irq.o
>> obj-$(CONFIG_MFD_PCF50633) += pcf50633.o
>> obj-$(CONFIG_PCF50633_ADC) += pcf50633-adc.o
>> diff --git a/drivers/mfd/mp2629.c b/drivers/mfd/mp2629.c
>> new file mode 100644
>> index 000000000000..41a4082387ce
>> --- /dev/null
>> +++ b/drivers/mfd/mp2629.c
>> @@ -0,0 +1,116 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * MP2629 MFD Driver for ADC and battery charger
> s/MFD Driver/parent driver/
>
>> + * Copyright 2020 Monolithic Power Systems, Inc
>> + *
>> + * Author: Saravanan Sekar <sravanhome@...il.com>
>> + */
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/i2c.h>
>> +#include <linux/regmap.h>
>> +#include <linux/slab.h>
>> +#include <linux/irq.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/mfd/core.h>
>> +#include <linux/mfd/mp2629.h>
> Alphabetical please.
>
>> +enum {
>> + MP2629_MFD_ADC,
>> + MP2629_MFD_CHARGER,
>> + MP2629_MFD_MAX
>> +};
>> +
>> +static struct resource mp2629_irq_rsrc[] = {
>> + {
>> + .flags = IORESOURCE_IRQ,
>> + },
>> +};
>> +
>> +static struct mfd_cell mp2629mfd[] = {
>> + [MP2629_MFD_ADC] = {
>> + .name = "mp2629_adc",
>> + .of_compatible = "mps,mp2629_adc",
>> + },
>> + [MP2629_MFD_CHARGER] = {
>> + .name = "mp2629_charger",
>> + .of_compatible = "mps,mp2629_charger",
>> + .resources = mp2629_irq_rsrc,
>> + .num_resources = ARRAY_SIZE(mp2629_irq_rsrc),
>> + }
>> +};
>> +
>> +static const struct regmap_config mp2629_regmap_config = {
>> + .reg_bits = 8,
>> + .val_bits = 8,
>> + .max_register = 0x17,
>> +};
>> +
>> +static int mp2629_probe(struct i2c_client *client)
>> +{
>> + struct mp2629_info *info;
> All this ddata instead of info.
Not sure the reason, I will do.
>
>> + struct resource *resources;
>> + int ret;
>> + int i;
>> +
>> + info = devm_kzalloc(&client->dev, sizeof(*info), GFP_KERNEL);
>> + if (!info)
>> + return -ENOMEM;
>> +
>> + info->dev = &client->dev;
>> + i2c_set_clientdata(client, info);
>> +
>> + info->regmap = devm_regmap_init_i2c(client, &mp2629_regmap_config);
>> + if (IS_ERR(info->regmap)) {
>> + dev_err(info->dev, "Failed to allocate regmap!\n");
>> + return PTR_ERR(info->regmap);
>> + }
>> +
>> + for (i = 0; i < MP2629_MFD_MAX; i++) {
>> + mp2629mfd[i].platform_data = &info->regmap;
>> + mp2629mfd[i].pdata_size = sizeof(info->regmap);
> You don't need to store this in platform data as well.
>
> You already have it in device data (ddata [currently 'info']).
"The IIO parts seems fine (minor comments inline) but I'm not keep on
directly accessing the internals of the mfd device info structure.
To my mind that should be opaque to the child drivers so as to provide
clear structure to any such accesses.
This mess in layering with the children directly using the parents
regmap is a little concerning. It means that the 3 drivers
really aren't very well separated and can't really be reviewed
independently (not a good thing)."
This is the review comments form Jonathan on V2, not to access parent
data structure directly.
Am I misunderstood his review comments? please suggest the better option
to follow as like in V2
or V2 + some improvements or V4 + improvements?
>> + resources = (struct resource *)mp2629mfd[i].resources;
>> + if (resources) {
>> + resources[0].start = client->irq;
>> + resources[0].end = client->irq;
>> + }
> You don't need to store this separately either.
>
> Just fetch it from the parent in the child device driver.
>
> It will look something like (untested, off the top of my head):
>
> platform_get_irq(to_platform_device(pdev->dev.parent), 0);
I have tested child got irq number correctly. Ok I will change it
>
>> + }
>> +
>> + ret = devm_mfd_add_devices(info->dev, PLATFORM_DEVID_NONE, mp2629mfd,
>> + ARRAY_SIZE(mp2629mfd), NULL,
>> + 0, NULL);
>> + if (ret)
>> + dev_err(info->dev, "Failed to add mfd %d\n", ret);
> "Failed to register sub-devices"
>
>> + return ret;
>> +}
>> +
>> +static const struct of_device_id mp2629_of_match[] = {
>> + { .compatible = "mps,mp2629"},
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, mp2629_of_match);
>> +
>> +static const struct i2c_device_id mp2629_id[] = {
>> + { "mp2629", },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(i2c, mp2629_id);
> You're already using .probe_new - this can be removed.
>
>> +static struct i2c_driver mp2629_driver = {
>> + .driver = {
>> + .name = "mp2629",
>> + .of_match_table = mp2629_of_match,
>> + },
>> + .probe_new = mp2629_probe,
>> + .id_table = mp2629_id,
>> +};
>> +module_i2c_driver(mp2629_driver);
>> +
>> +MODULE_AUTHOR("Saravanan Sekar <sravanhome@...il.com>");
>> +MODULE_DESCRIPTION("MP2629 Battery charger mfd driver");
> "parent driver"
>
>> +MODULE_LICENSE("GPL");
>> diff --git a/include/linux/mfd/mp2629.h b/include/linux/mfd/mp2629.h
>> new file mode 100644
>> index 000000000000..371e44330ba8
>> --- /dev/null
>> +++ b/include/linux/mfd/mp2629.h
>> @@ -0,0 +1,22 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>> +/*
>> + * mp2629.h - register definitions for mp2629 charger
> Remove the filename.
>
> s/mp2629/MP2629/
>
>> + * Copyright 2020 Monolithic Power Systems, Inc
>> + *
> Superfluous '\n'.
>
>> + */
>> +
>> +#ifndef __MP2629_H__
>> +#define __MP2629_H__
>> +
>> +#include <linux/types.h>
>> +
>> +struct device;
>> +struct regmap;
> Why not just add the includes?
Some more shared enum added in ADC driver
>> +struct mp2629_info {
>> + struct device *dev;
>> + struct regmap *regmap;
>> +};
>> +
>> +#endif
Thanks,
Saravanan
Powered by blists - more mailing lists