linux-kernel - Re: [PATCH v8 3/3] perf x86: Exposing an Uncore unit to PMON for Intel Xeon® server platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875zeq6v5v.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Fri, 27 Mar 2020 10:47:56 +0200
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     roman.sudarikov@...ux.intel.com, peterz@...radead.org,
        mingo@...hat.com, acme@...nel.org, mark.rutland@....com,
        jolsa@...hat.com, namhyung@...nel.org,
        linux-kernel@...r.kernel.org, eranian@...gle.com,
        bgregg@...flix.com, ak@...ux.intel.com, kan.liang@...ux.intel.com
Cc:     alexander.antonov@...el.com, roman.sudarikov@...ux.intel.com,
        alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH v8 3/3] perf x86: Exposing an Uncore unit to PMON for
 Intel Xeon® server platform

roman.sudarikov@...ux.intel.com writes:

> ---
>  .../ABI/testing/sysfs-devices-mapping         |  33 +++
>  arch/x86/events/intel/uncore.h                |   9 +
>  arch/x86/events/intel/uncore_snbep.c          | 191 ++++++++++++++++++
>  3 files changed, 233 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-devices-mapping
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-mapping b/Documentation/ABI/testing/sysfs-devices-mapping
> new file mode 100644
> index 000000000000..16f4e900be7b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-devices-mapping

Is this a good place for something that's perf/x86/intel/uncore
specific?

> +                Which means:
> +                IIO PMU 0 on die 0 belongs to PCI RP on bus 0x00, domain 0x0000
> +                IIO PMU 0 on die 1 belongs to PCI RP on bus 0x40, domain 0x0000
> +                IIO PMU 0 on die 2 belongs to PCI RP on bus 0x80, domain 0x0000
> +                IIO PMU 0 on die 3 belongs to PCI RP on bus 0xc0, domain 0x0000
> \ No newline at end of file

Git is trying to tell you something.

> +		eas[die].attr.attr.mode = 0444;

I believe this one is also known as S_IRUGO.

Other than that, this patch is

Reviewed-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>

Regards,
--
Alex