linux-kernel - RE: [PATCH v3 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYAPR01MB4544104071EEA9DA9BF86B96D8CC0@TYAPR01MB4544.jpnprd01.prod.outlook.com>
Date:   Fri, 27 Mar 2020 09:19:19 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Kishon Vijay Abraham I <kishon@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v3 1/4] dt-bindings: phy: renesas: usb2-phy: convert
 bindings to json-schema

Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Friday, March 27, 2020 5:55 PM
<snip>
> > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> > +++ /dev/null
> 
> > -The phandle's argument in the PHY specifier is the INT_STATUS bit of controller:
> > -- 1 = USBH_INTA (OHCI)
> > -- 2 = USBH_INTB (EHCI)
> > -- 3 = UCOM_INT (OTG and BC)
> 
> Sorry, I failed to notice during my previous review that the above information
> is lost during the conversion.  I think it would be good to retain it in the
> description for #phy-cells.

I agree. I'll add it.

> With that added:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Thanks!

Best regards,
Yoshihiro Shimoda