linux-kernel - Re: [PATCH net-next v3 07/11] net: ethernet: ti: cpts: rework locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Mar 2020 18:28:24 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Lokesh Vutla <lokeshvutla@...com>,
        Tony Lindgren <tony@...mide.com>, Sekhar Nori <nsekhar@...com>,
        Murali Karicheri <m-karicheri2@...com>,
        netdev <netdev@...r.kernel.org>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 07/11] net: ethernet: ti: cpts: rework locking

On Fri, Mar 20, 2020 at 09:42:40PM +0200, Grygorii Strashko wrote:
> Now spinlock is used to synchronize everything which is not required. Add
> mutex and use to sync access to PTP interface and PTP worker and use
> spinlock only to sync FIFO/events processing.

If you haven't already, I suggest testing this change with lockdep
enabled.

Thanks,
Richard