linux-kernel - Re: [PATCH] iommu: Lower severity of add/remove device messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e863f96cd9a188db84ae8bc5a0d49287b4b4922.camel@collabora.com>
Date:   Fri, 27 Mar 2020 10:02:11 -0300
From:   Ezequiel Garcia <ezequiel@...labora.com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     iommu@...ts.linux-foundation.org, kernel@...labora.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: Lower severity of add/remove device messages

Hello Joerg,

Thanks for reviewing.

I understand this change bears some controversy
for IOMMU, as developers are probably used to see these
messages.

On Fri, 2020-03-27 at 10:50 +0100, Joerg Roedel wrote:
> On Mon, Mar 23, 2020 at 06:49:56PM -0300, Ezequiel Garcia wrote:
> > These user messages are not really informational,
> > but mostly of debug nature. Lower their severity.
> 
> Like most other messages in the kernel log, that is not a reason to
> lower the severity.
>
> These messages are the first thing to look at when
> looking into IOMMU related issues.
> 

Sure, but the messages are still here, you can
always enable them when you are looking at IOMMU issues :-)

The idea is to reduce the amount of verbosity in the kernel.

If all subsystems would print messages that are useful
when looking at issues, things would be quite nasty verbose.

Thanks!
Ezequiel