linux-kernel - Re: [PATCH v9 52/55] input: touchscreen: atmel_mxt_ts: Added sysfs entry for touchscreen status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7f77683-f86d-5e23-6afc-96834cbb55cc@gmail.com>
Date:   Fri, 27 Mar 2020 16:43:53 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     "Wang, Jiada" <jiada_wang@...tor.com>, nick@...anahar.org,
        dmitry.torokhov@...il.com, jikos@...nel.org,
        benjamin.tissoires@...hat.com, bsz@...ihalf.com,
        rydberg@...math.org
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        erosca@...adit-jv.com, Andrew_Gabbasov@...tor.com
Subject: Re: [PATCH v9 52/55] input: touchscreen: atmel_mxt_ts: Added sysfs
 entry for touchscreen status

27.03.2020 16:37, Dmitry Osipenko пишет:
> 27.03.2020 15:49, Wang, Jiada пишет:
>>>> +static void mxt_watchdog_work(struct work_struct *work)
>>>> +{
>>>> +    struct mxt_data *data =
>>>> +        container_of(work, struct mxt_data, watchdog_work);
>>>> +    u16 info_buf;
>>>> +    int ret = 0;
>>>> +    u8 size = 2;

There is no need to initialize the ret variable.

>>>> +    if (data->suspended || data->in_bootloader)
>>>> +        return;
>>>> +
>>>> +    ret = __mxt_read_reg(data->client, 0, size, &info_buf);

The "size" argument could be replaced with "sizeof(info_buf)".