linux-kernel - Re: [PATCH 2/2] media: Remove VIDEO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200327151020.231cf045@coco.lan>
Date:   Fri, 27 Mar 2020 15:10:20 +0100
From:   Mauro Carvalho Chehab <mchehab@...nel.org>
To:     Ezequiel Garcia <ezequiel@...labora.com>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tomasz Figa <tfiga@...omium.org>,
        Nicolas Dufresne <nicolas@...fresne.ca>, kernel@...labora.com,
        Hans Verkuil <hverkuil@...all.nl>, Sean Young <sean@...s.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@....fi>,
        Michael Ira Krufky <mkrufky@...il.com>,
        Helen Koike <helen.koike@...labora.com>
Subject: Re: [PATCH 2/2] media: Remove VIDEO_DEV unneeded dependency

Em Fri, 27 Mar 2020 10:47:44 -0300
Ezequiel Garcia <ezequiel@...labora.com> escreveu:

> Hi Mauro,
> 
> On Tue, 2020-03-24 at 07:18 -0300, Ezequiel Garcia wrote:
> > On Tue, 2020-03-24 at 10:47 +0100, Mauro Carvalho Chehab wrote:  
> > > Em Mon, 23 Mar 2020 18:10:22 -0300
> > > Ezequiel Garcia <ezequiel@...labora.com> escreveu:
> > >   
> > > > Enable VIDEO_DEV (which compiles Video4Linux core)
> > > > when MEDIA_SUPPORT is selected. This is needed, in order
> > > > to be able to enable devices such as stateless codecs.
> > > > 
> > > > Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>
> > > > ---
> > > >  drivers/media/Kconfig | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > > > index b36a41332867..7de472ad07a2 100644
> > > > --- a/drivers/media/Kconfig
> > > > +++ b/drivers/media/Kconfig
> > > > @@ -93,13 +93,11 @@ source "drivers/media/mc/Kconfig"
> > > >  
> > > >  #
> > > >  # Video4Linux support
> > > > -#	Only enables if one of the V4L2 types (ATV, webcam, radio) is selected
> > > >  #
> > > >  
> > > >  config VIDEO_DEV
> > > >  	tristate
> > > >  	depends on MEDIA_SUPPORT
> > > > -	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
> > > >  	default y
> > > >  
> > > >  config VIDEO_V4L2_SUBDEV_API  
> > > 
> > > The rationale of the above is to exclude Digital TV and remote
> > > controller.
> > > 
> > > Removing the above will make the V4L2 core available every time, even
> > > if all the user wants is remote controller or Digital TV support.
> > >   
> > 
> > Hm, right.
> >   
> > > I'm working on a patchset that should hopefully address the issues
> > > you're concerning.
> > >   
> > 
> > Thanks, I'll appreciate that.
> >   
> 
> It seems the config rework you sent will undergo some
> extended discussions, which is fine given it's a full rework.
> 
> I'd like to send a smaller (ideally just one or two patches)
> series, so we can improve the situation on codecs on a smaller
> timeframe.

I won't be merging anything new until the end of the merge
window. So, we have around 20 days where no patches will
be merged at linux media (except by critical bug fixes,
merge conflicts, build breakages and similar stuff).

So, there are plenty of time to review such series.

Thanks,
Mauro