linux-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 Mar 2020 08:53:20 -0700
From:   Lee Duncan <lduncan@...e.com>
To:     <chenanqing@...o.com>, <linux-kernel@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>, <open-iscsi@...glegroups.com>,
        <ceph-devel@...r.kernel.org>, <martin.petersen@...cle.com>,
        <jejb@...ux.ibm.com>, <cleech@...hat.com>
Subject: Re:

On 3/27/20 2:20 AM, chenanqing@...o.com wrote:
> From: Chen Anqing <chenanqing@...o.com>
> To: Lee Duncan <lduncan@...e.com>
> Cc: Chris Leech <cleech@...hat.com>,
>         "James E . J . Bottomley" <jejb@...ux.ibm.com>,
>         "Martin K . Petersen" <martin.petersen@...cle.com>,
>         ceph-devel@...r.kernel.org,
>         open-iscsi@...glegroups.com,
>         linux-scsi@...r.kernel.org,
>         linux-kernel@...r.kernel.org,
>         chenanqing@...o.com
> Subject: [PATCH] scsi: libiscsi: we should take compound page into account also
> Date: Fri, 27 Mar 2020 05:20:01 -0400
> Message-Id: <20200327092001.56879-1-chenanqing@...o.com>
> X-Mailer: git-send-email 2.18.2
> 
> the patch is occur at a real crash,which slab is
> come from a compound page,so we need take the compound page
> into account also.
> fixed commit 08b11eaccfcf ("scsi: libiscsi: fall back to
> sendmsg for slab pages").
> 
> Signed-off-by: Chen Anqing <chenanqing@...o.com>
> ---
>  drivers/scsi/libiscsi_tcp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
> index 6ef93c7af954..98304e5e1f6f 100644
> --- a/drivers/scsi/libiscsi_tcp.c
> +++ b/drivers/scsi/libiscsi_tcp.c
> @@ -128,7 +128,8 @@ static void iscsi_tcp_segment_map(struct iscsi_segment *segment, int recv)
>          * coalescing neighboring slab objects into a single frag which
>          * triggers one of hardened usercopy checks.
>          */
> -       if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)))
> +       if (!recv && page_count(sg_page(sg)) >= 1 &&
> +           !PageSlab(compound_head(sg_page(sg))))
>                 return;
> 
>         if (recv) {
> --
> 2.18.2
> 


This is missing a proper subject ...