linux-kernel - Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <015ad553-86a2-c6ac-e515-f14df83cec26@gmail.com>
Date:   Fri, 27 Mar 2020 17:15:53 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Rob Herring <robh+dt@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com
Cc:     devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware
 bus



On 26/03/2020 14:44, Nicolas Saenz Julienne wrote:
> With the introduction of 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's
> firmware bus DMA limitations") the firmware bus has to comply with
> /soc's DMA limitations. Ultimately linking both buses to a same
> dma-ranges property. The patch (and author) missed the fact that a bus'
> #address-cells and #size-cells properties are not inherited, but set to
> a fixed value which, in this case, doesn't match /soc's. This, although
> not breaking Linux's DMA mapping functionality, generates ugly dtc
> warnings.
> 
> Fix the issue by adding the correct address and size cells properties
> under the firmware bus.
> 
> Fixes: 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA limitations")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>

Reviewed-by: Matthias Brugger <mbrugger@...e.com>

> ---
>  arch/arm/boot/dts/bcm2835-rpi.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index fd2c766e0f71..f7ae5a4530b8 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -14,6 +14,9 @@ act {
>  	soc {
>  		firmware: firmware {
>  			compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
>  			mboxes = <&mailbox>;
>  			dma-ranges;
>  		};
>