linux-kernel - Re: [PATCH v4 5/8] usb: mausb_host: Introduce PAL processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.2003271233160.14887-100000@netrider.rowland.org>
Date:   Fri, 27 Mar 2020 12:35:59 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     vladimir.stankovic@...playlink.com
cc:     gregkh@...uxfoundation.org, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <mausb-host-devel@...playlink.com>
Subject: Re: [PATCH v4 5/8] usb: mausb_host: Introduce PAL processing

On Fri, 27 Mar 2020 vladimir.stankovic@...playlink.com wrote:

> Protocol adaptation layer (PAL) implementation has been added to
> introduce MA-USB structures and logic.
> 
> Signed-off-by: Vladimir Stankovic <vladimir.stankovic@...playlink.com>
> ---
> +	/*
> +	 * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it
> +	 * should not, so it is breaking the USB drive on the linux
> +	 */
> +	urb->transfer_flags &= ~URB_SHORT_NOT_OK;

Please explain more fully.  What SCSI driver are you talking about?  
Where is the flag getting added incorrectly?  What USB drive is getting
broken, and how?

If there's a bug in a SCSI driver, why don't you report it and get it
fixed instead of trying to create a workaround in just one host 
controller driver?

Alan Stern