linux-kernel - Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05354cea-756c-640e-24d7-272eafd69ef1@gmail.com>
Date:   Fri, 27 Mar 2020 17:48:53 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Rob Herring <robh+dt@...nel.org>, Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com
Cc:     devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware
 bus



On 27/03/2020 17:17, Florian Fainelli wrote:
> 
> 
> On 3/27/2020 9:15 AM, Matthias Brugger wrote:
>>
>>
>> On 26/03/2020 14:44, Nicolas Saenz Julienne wrote:
>>> With the introduction of 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's
>>> firmware bus DMA limitations") the firmware bus has to comply with
>>> /soc's DMA limitations. Ultimately linking both buses to a same
>>> dma-ranges property. The patch (and author) missed the fact that a bus'
>>> #address-cells and #size-cells properties are not inherited, but set to
>>> a fixed value which, in this case, doesn't match /soc's. This, although
>>> not breaking Linux's DMA mapping functionality, generates ugly dtc
>>> warnings.
>>>
>>> Fix the issue by adding the correct address and size cells properties
>>> under the firmware bus.
>>>
>>> Fixes: 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA limitations")
>>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
>>
>> Reviewed-by: Matthias Brugger <mbrugger@...e.com>
> 
> Should this be squashed into "ARM: dts: bcm283x: Fix vc4's firmware bus
> DMA limitations"? I have not gotten a response it has been accepted yet.
> 

Well I think if we can squash the two instead of providing a Fixes-tag, even better.

Regards,
Matthias