linux-kernel - Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1442ebf-b094-f16c-3cf5-10159d2fd12b@gmail.com>
Date:   Fri, 27 Mar 2020 18:02:01 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        linux-kernel@...r.kernel.org
Cc:     Collabora Kernel ML <kernel@...labora.com>, drinkcat@...omium.org,
        hsinyi@...omium.org, Anders Roxell <anders.roxell@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols



On 26/03/2020 19:27, Enric Balletbo i Serra wrote:
> When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see
> the following error.
> 
>   ERROR: modpost: "mtk_mmsys_ddp_disconnect"
>   [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>   ERROR: modpost: "mtk_mmsys_ddp_connect"
>   [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
> 
> Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be
> able to be used for other modules.
> 
> Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
> Reported-by: Anders Roxell <anders.roxell@...aro.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

I squashed this into the old commit:
396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")

And pushed it out to v5.6-next/soc

Thanks!

> ---
> 
>  drivers/soc/mediatek/mtk-mmsys.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 32a92ec447c5..05e322c9c301 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev,
>  		writel_relaxed(reg, config_regs + addr);
>  	}
>  }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect);
>  
>  void mtk_mmsys_ddp_disconnect(struct device *dev,
>  			      enum mtk_ddp_comp_id cur,
> @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
>  		writel_relaxed(reg, config_regs + addr);
>  	}
>  }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>  
>  static int mtk_mmsys_probe(struct platform_device *pdev)
>  {
>