linux-kernel - Re: [PATCH net-next v2 11/12] ethtool: add timestamping related string sets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200327194354.GI31519@unicorn.suse.cz>
Date:   Fri, 27 Mar 2020 20:43:54 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     netdev@...r.kernel.org
Cc:     Richard Cochran <richardcochran@...il.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 11/12] ethtool: add timestamping related
 string sets

On Fri, Mar 27, 2020 at 11:53:44AM -0700, Richard Cochran wrote:
> On Fri, Mar 27, 2020 at 03:08:12PM +0100, Michal Kubecek wrote:
> > +const char ts_tx_type_names[][ETH_GSTRING_LEN] = {
> > +	[HWTSTAMP_TX_OFF]		= "off",
> > +	[HWTSTAMP_TX_ON]		= "on",
> > +	[HWTSTAMP_TX_ONESTEP_SYNC]	= "one-step-sync",
> > +	[HWTSTAMP_TX_ONESTEP_P2P]	= "one-step-p2p",
> > +};
> 
> Suggest "onestep-sync" and "onestep-p2p".

I copied "one-step-sync" from (userspace) ethtool but I guess we don't
have to be 100% backward compatible. It would match the constant name
better without dash.

Michal

> Acked-by: Richard Cochran <richardcochran@...il.com>