linux-kernel - Re: [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200327195239.GA28087@bogus>
Date:   Fri, 27 Mar 2020 13:52:39 -0600
From:   Rob Herring <robh@...nel.org>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <maz@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Brown <broonie@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx to json-schema

On Tue, Mar 17, 2020 at 10:39:20AM +0100, Lubomir Rintel wrote:
> A straightforward conversion of the the spi-pxa2xx binding to DT schema
> format using json-schema.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> ---
>  .../bindings/spi/marvell,mmp2-ssp.yaml        | 58 +++++++++++++++++++
>  .../devicetree/bindings/spi/spi-pxa2xx.txt    | 27 ---------
>  2 files changed, 58 insertions(+), 27 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
>  delete mode 100644 Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> 
> diff --git a/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> new file mode 100644
> index 0000000000000..de6b6a53b70d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)

Same issue on license...

> +# Copyright 2019,2020 Lubomir Rintel <lkundrak@...sk>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/marvell,mmp2-ssp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PXA2xx SSP SPI Controller bindings
> +
> +maintainers:
> +  - Lubomir Rintel <lkundrak@...sk>
> +
> +allOf:
> +  - $ref: spi-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: marvell,mmp2-ssp
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  ready-gpios:
> +    description: |
> +      GPIO used to signal a SPI master that the FIFO is filled and we're
> +      ready to service a transfer. Only useful in slave mode.
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks

> +  - '#address-cells'
> +  - '#size-cells'

spi-controller.yaml handles these being required and also that they 
aren't for slave mode.

> +
> +dependencies:
> +  ready-gpios: [ spi-slave ]
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/marvell,mmp2.h>
> +    spi@...35000 {
> +        compatible = "marvell,mmp2-ssp";
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        reg = <0xd4035000 0x1000>;
> +        clocks = <&soc_clocks MMP2_CLK_SSP0>;
> +        interrupts = <0>;
> +    };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> deleted file mode 100644
> index e30e0c2a4bce1..0000000000000
> --- a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -PXA2xx SSP SPI Controller
> -
> -Required properties:
> -- compatible: Must be "marvell,mmp2-ssp".
> -- reg: Offset and length of the device's register set.
> -- interrupts: Should be the interrupt number.
> -- clocks: Should contain a single entry describing the clock input.
> -- #address-cells:  Number of cells required to define a chip select address.
> -- #size-cells: Should be zero.
> -
> -Optional properties:
> -- cs-gpios: list of GPIO chip selects. See the SPI bus bindings,
> -  Documentation/devicetree/bindings/spi/spi-bus.txt
> -- spi-slave: Empty property indicating the SPI controller is used in slave mode.
> -- ready-gpios: GPIO used to signal a SPI master that the FIFO is filled
> -  and we're ready to service a transfer. Only useful in slave mode.
> -
> -Child nodes represent devices on the SPI bus
> -  See ../spi/spi-bus.txt
> -
> -Example:
> -	ssp1: spi@...35000 {
> -		compatible = "marvell,mmp2-ssp";
> -		reg = <0xd4035000 0x1000>;
> -		clocks = <&soc_clocks MMP2_CLK_SSP0>;
> -		interrupts = <0>;
> -	};
> -- 
> 2.25.1
>