linux-kernel - Re: [PATCH v1 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Mar 2020 20:37:11 +0000
From:   "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>
To:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "Kammela, Gayatri" <gayatri.kammela@...el.com>
CC:     "dvhart@...radead.org" <dvhart@...radead.org>,
        "alex.hung@...onical.com" <alex.hung@...onical.com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "amit.kucheria@...durent.com" <amit.kucheria@...durent.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "Westerberg, Mika" <mika.westerberg@...el.com>,
        "Prestopine, Charles D" <charles.d.prestopine@...el.com>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v1 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs

On Fri, 2020-03-27 at 13:24 -0700, Gayatri Kammela wrote:
> Tiger Lake's new unique ACPI device IDs for DPTF and fan drivers are
> not
> valid as the IDs are missing 'C'. Fix the IDs by updating them.
> 
> After the update, the new IDs should now look like
> INT1047 --> INTC1047
> INT1040 --> INTC1040
> INT1043 --> INTC1043
> INT1044 --> INTC1044
> 
We need Fixes tag.

For example

Fixes: 55cfe6a5c582 ("ACPI: DPTF: Add Tiger Lake ACPI device IDs")
Cc: 5.6+ <stable@...r.kernel.org> # 5.6+

By the time this patch is merged I guess the 5.6 will be out.

> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...el.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@...el.com>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@...el.com>
> ---
>  drivers/acpi/device_pm.c            | 2 +-
>  drivers/acpi/dptf/dptf_power.c      | 2 +-
>  drivers/acpi/dptf/int340x_thermal.c | 8 ++++----
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
> index b64c62bfcea5..80dae3b3c36a 100644
> --- a/drivers/acpi/device_pm.c
> +++ b/drivers/acpi/device_pm.c
> @@ -1321,7 +1321,7 @@ int acpi_dev_pm_attach(struct device *dev, bool
> power_on)
>  	 */
>  	static const struct acpi_device_id special_pm_ids[] = {
>  		{"PNP0C0B", }, /* Generic ACPI fan */
> -		{"INT1044", }, /* Fan for Tiger Lake generation */
> +		{"INTC1044", }, /* Fan for Tiger Lake generation */
>  		{"INT3404", }, /* Fan */
>  		{}
>  	};
> diff --git a/drivers/acpi/dptf/dptf_power.c
> b/drivers/acpi/dptf/dptf_power.c
> index 387f27ef3368..e5fb34bfa52c 100644
> --- a/drivers/acpi/dptf/dptf_power.c
> +++ b/drivers/acpi/dptf/dptf_power.c
> @@ -97,7 +97,7 @@ static int dptf_power_remove(struct platform_device
> *pdev)
>  }
>  
>  static const struct acpi_device_id int3407_device_ids[] = {
> -	{"INT1047", 0},
> +	{"INTC1047", 0},
>  	{"INT3407", 0},
>  	{"", 0},
>  };
> diff --git a/drivers/acpi/dptf/int340x_thermal.c
> b/drivers/acpi/dptf/int340x_thermal.c
> index 1ec7b6900662..29b5c77256dd 100644
> --- a/drivers/acpi/dptf/int340x_thermal.c
> +++ b/drivers/acpi/dptf/int340x_thermal.c
> @@ -13,10 +13,10 @@
>  
>  #define INT3401_DEVICE 0X01
>  static const struct acpi_device_id int340x_thermal_device_ids[] = {
> -	{"INT1040"},
> -	{"INT1043"},
> -	{"INT1044"},
> -	{"INT1047"},
> +	{"INTC1040"},
> +	{"INTC1043"},
> +	{"INTC1044"},
> +	{"INTC1047"},
>  	{"INT3400"},
>  	{"INT3401", INT3401_DEVICE},
>  	{"INT3402"},