[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200327221545.GF5063@builder>
Date: Fri, 27 Mar 2020 15:15:45 -0700
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Thara Gopinath <thara.gopinath@...aro.org>
Cc: rui.zhang@...el.com, ulf.hansson@...aro.org,
daniel.lezcano@...aro.org, agross@...nel.org, robh@...nel.org,
amit.kucheria@...durent.com, mark.rutland@....com,
rjw@...ysocki.net, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [Patch v5 2/6] soc: qcom: rpmhpd: Introduce function to retrieve
power domain performance state count
On Thu 19 Mar 18:41 PDT 2020, Thara Gopinath wrote:
> Populate .get_performace_state_count in genpd ops to retrieve the count of
> performance states supported by a rpmh power domain.
>
> Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>
> Signed-off-by: Thara Gopinath <thara.gopinath@...aro.org>
> ---
> drivers/soc/qcom/rpmhpd.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 4d264d0672c4..7142409a3b77 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -341,6 +341,13 @@ static unsigned int rpmhpd_get_performance_state(struct generic_pm_domain *genpd
> return dev_pm_opp_get_level(opp);
> }
>
> +static int rpmhpd_performance_states_count(struct generic_pm_domain *domain)
> +{
> + struct rpmhpd *pd = domain_to_rpmhpd(domain);
> +
> + return pd->level_count;
> +}
> +
> static int rpmhpd_update_level_mapping(struct rpmhpd *rpmhpd)
> {
> int i;
> @@ -429,6 +436,8 @@ static int rpmhpd_probe(struct platform_device *pdev)
> rpmhpds[i]->pd.power_on = rpmhpd_power_on;
> rpmhpds[i]->pd.set_performance_state = rpmhpd_set_performance_state;
> rpmhpds[i]->pd.opp_to_performance_state = rpmhpd_get_performance_state;
> + rpmhpds[i]->pd.get_performance_state_count =
> + rpmhpd_performance_states_count;
I would prefer if you ignore the 80-char limit here and leave the line
unwrapped.
Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
Regards,
Bjorn
> pm_genpd_init(&rpmhpds[i]->pd, NULL, true);
>
> data->domains[i] = &rpmhpds[i]->pd;
> --
> 2.20.1
>
Powered by blists - more mailing lists