linux-kernel - Re: [PATCH net-next v3 00/12] ethtool netlink interface, part 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200328100805.GO11304@nanopsycho.orion>
Date:   Sat, 28 Mar 2020 11:08:05 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        Johannes Berg <johannes@...solutions.net>,
        Richard Cochran <richardcochran@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 00/12] ethtool netlink interface, part 4

Sat, Mar 28, 2020 at 12:00:58AM CET, mkubecek@...e.cz wrote:
>Implementation of more netlink request types:
>
>  - coalescing (ethtool -c/-C, patches 2-4)
>  - pause parameters (ethtool -a/-A, patches 5-7)
>  - EEE settings (--show-eee / --set-eee, patches 8-10)
>  - timestamping info (-T, patches 11-12)
>
>Patch 1 is a fix for netdev reference leak similar to commit 2f599ec422ad
>("ethtool: fix reference leak in some *_SET handlers") but fixing a code
>
>Changes in v3
>  - change "one-step-*" Tx type names to "onestep-*", (patch 11, suggested
>    by Richard Cochran
>  - use "TSINFO" rather than "TIMESTAMP" for timestamping information
>    constants and adjust symbol names (patch 12, suggested by Richard
>    Cochran)
>
>Changes in v2:
>  - fix compiler warning in net_hwtstamp_validate() (patch 11)
>  - fix follow-up lines alignment (whitespace only, patches 3 and 8)
>which is only in net-next tree at the moment.
>
>Michal Kubecek (12):
>  ethtool: fix reference leak in ethnl_set_privflags()
>  ethtool: provide coalescing parameters with COALESCE_GET request
>  ethtool: set coalescing parameters with COALESCE_SET request
>  ethtool: add COALESCE_NTF notification
>  ethtool: provide pause parameters with PAUSE_GET request
>  ethtool: set pause parameters with PAUSE_SET request
>  ethtool: add PAUSE_NTF notification
>  ethtool: provide EEE settings with EEE_GET request
>  ethtool: set EEE settings with EEE_SET request
>  ethtool: add EEE_NTF notification
>  ethtool: add timestamping related string sets
>  ethtool: provide timestamping information with TSINFO_GET request

FWIW, this looks fine to me.
set-
Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks Michal!