linux-kernel - [tip: locking/core] generic arch_futex_atomic_op_inuser() doesn't need access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 28 Mar 2020 11:06:17 -0000
From:   "tip-bot2 for Al Viro" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Al Viro <viro@...iv.linux.org.uk>, x86 <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: [tip: locking/core] generic arch_futex_atomic_op_inuser() doesn't
 need access_ok()

The following commit has been merged into the locking/core branch of tip:

Commit-ID:     a251b2d513ea4116ddb5487610e4b4048c7aa397
Gitweb:        https://git.kernel.org/tip/a251b2d513ea4116ddb5487610e4b4048c7aa397
Author:        Al Viro <viro@...iv.linux.org.uk>
AuthorDate:    Tue, 18 Feb 2020 12:19:23 -05:00
Committer:     Al Viro <viro@...iv.linux.org.uk>
CommitterDate: Fri, 27 Mar 2020 23:58:55 -04:00

generic arch_futex_atomic_op_inuser() doesn't need access_ok()

uses get_user() and put_user() for memory accesses

Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
---
 include/asm-generic/futex.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/asm-generic/futex.h b/include/asm-generic/futex.h
index 3eab7ba..f4c3470 100644
--- a/include/asm-generic/futex.h
+++ b/include/asm-generic/futex.h
@@ -33,8 +33,6 @@ arch_futex_atomic_op_inuser(int op, u32 oparg, int *oval, u32 __user *uaddr)
 	int oldval, ret;
 	u32 tmp;
 
-	if (!access_ok(uaddr, sizeof(u32)))
-		return -EFAULT;
 	preempt_disable();
 
 	ret = -EFAULT;