linux-kernel - [tip: locking/core] sh: no need of access_ok() in arch_futex_atomic_op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 28 Mar 2020 11:06:19 -0000
From:   "tip-bot2 for Al Viro" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Al Viro <viro@...iv.linux.org.uk>, x86 <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: [tip: locking/core] sh: no need of access_ok() in
 arch_futex_atomic_op_inuser()

The following commit has been merged into the locking/core branch of tip:

Commit-ID:     0bea4f7beb68db927a05ff4c08b3ce9f32d043f9
Gitweb:        https://git.kernel.org/tip/0bea4f7beb68db927a05ff4c08b3ce9f32d043f9
Author:        Al Viro <viro@...iv.linux.org.uk>
AuthorDate:    Sun, 16 Feb 2020 10:27:46 -05:00
Committer:     Al Viro <viro@...iv.linux.org.uk>
CommitterDate: Fri, 27 Mar 2020 23:58:52 -04:00

sh: no need of access_ok() in arch_futex_atomic_op_inuser()

everything it uses is doing access_ok() already

Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
---
 arch/sh/include/asm/futex.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/sh/include/asm/futex.h b/arch/sh/include/asm/futex.h
index 324fa68..b39cda0 100644
--- a/arch/sh/include/asm/futex.h
+++ b/arch/sh/include/asm/futex.h
@@ -34,9 +34,6 @@ static inline int arch_futex_atomic_op_inuser(int op, u32 oparg, int *oval,
 	u32 oldval, newval, prev;
 	int ret;
 
-	if (!access_ok(uaddr, sizeof(u32)))
-		return -EFAULT;
-
 	do {
 		ret = get_user(oldval, uaddr);