linux-kernel - Re: [PATCH] MIPS: ralink: mt7621: Fix soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200328120632.Horde.u68iv-GbxRgnXZTYfkNn0hr@www.vdorst.com>
Date:   Sat, 28 Mar 2020 12:06:32 +0000
From:   René van Dorst <opensource@...rst.com>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     John Crispin <john@...ozen.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] MIPS: ralink: mt7621: Fix soc_device introduction

Hi Thomas,

Thanks for fixing the compile issue for me.
Now I can make a kernel again.

Tested-by: René van Dorst <opensource@...rst.com>

Greats,

René

Quoting Thomas Bogendoerfer <tsbogend@...ha.franken.de>:

> Depending on selected SMP config options soc_device didn't get
> initialised at all. With UP config vmlinux didn't link because
> of missing soc bus.
>
> Fixes: 71b9b5e0130d ("MIPS: ralink: mt7621: introduce 'soc_device'  
> initialization")
> Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> ---
>  arch/mips/ralink/Kconfig  | 1 +
>  arch/mips/ralink/mt7621.c | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
> index 94e9ce994494..35c2ebd8f094 100644
> --- a/arch/mips/ralink/Kconfig
> +++ b/arch/mips/ralink/Kconfig
> @@ -52,6 +52,7 @@ choice
>  		select COMMON_CLK
>  		select CLKSRC_MIPS_GIC
>  		select HAVE_PCI if PCI_MT7621
> +		select SOC_BUS
>  endchoice
>
>  choice
> diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c
> index 905460aeeb1f..0accb80db709 100644
> --- a/arch/mips/ralink/mt7621.c
> +++ b/arch/mips/ralink/mt7621.c
> @@ -243,12 +243,12 @@ void prom_soc_init(struct ralink_soc_info *soc_info)
>
>  	rt2880_pinmux_data = mt7621_pinmux_data;
>
> +	soc_dev_init(soc_info, rev);
> +
>  	if (!register_cps_smp_ops())
>  		return;
>  	if (!register_cmp_smp_ops())
>  		return;
>  	if (!register_vsmp_smp_ops())
>  		return;
> -
> -	soc_dev_init(soc_info, rev);
>  }
> --
> 2.16.4