linux-kernel - Re: [PATCH v2 02/13] iio: st_sensors_i2c: Use vsprintf extension %pe for symbolic error name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Mar 2020 14:11:33 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Nishant Malpani <nish.malpani25@...il.com>
Cc:     andriy.shevchenko@...ux.intel.com, joe@...ches.com,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/13] iio: st_sensors_i2c: Use vsprintf extension
 %pe for symbolic error name

On Sun, 22 Mar 2020 22:53:04 +0530
Nishant Malpani <nish.malpani25@...il.com> wrote:

> Utilize %pe format specifier from vsprintf while printing error logs
> with dev_err(). Discards the use of unnecessary explicit casting and
> prints symbolic error name which might prove to be convenient during
> debugging.
> 
> Signed-off-by: Nishant Malpani <nish.malpani25@...il.com>
This one doesn't apply because the original 'fix' that the whole series
was based on from Andy has already been applied.

Whilst you could propose a change on top of that it probably isn't
worth the effort, so unless others disagree I'd just drop this one.

Thanks,

Jonathan

> ---
> 
> Changes in v2:
>   - Rewrite commit subject line outlining the usage of %pe.
>   - Add a separator between regmap and its error name.
> 
> Based on conversations in [1] & [2].
> 
> [1] https://marc.info/?l=linux-iio&m=158427554607223&w=2
> [2] https://marc.info/?l=linux-iio&m=158481647605891&w=2
> ---
>  drivers/iio/common/st_sensors/st_sensors_i2c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/common/st_sensors/st_sensors_i2c.c b/drivers/iio/common/st_sensors/st_sensors_i2c.c
> index 286830fb5d35..4f7ae273ac98 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_i2c.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_i2c.c
> @@ -49,8 +49,8 @@ int st_sensors_i2c_configure(struct iio_dev *indio_dev,
>  
>  	sdata->regmap = devm_regmap_init_i2c(client, config);
>  	if (IS_ERR(sdata->regmap)) {
> -		dev_err(&client->dev, "Failed to register i2c regmap (%d)\n",
> -			(int)PTR_ERR(sdata->regmap));
> +		dev_err(&client->dev, "Failed to register i2c regmap: %pe\n",
> +			sdata->regmap);
>  		return PTR_ERR(sdata->regmap);
>  	}
>