linux-kernel - Re: [PATCH RFC v2 tip/core/rcu 14/22] rcu-tasks: Add an RCU Tasks Trace to simplify protection of tracing hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Mar 2020 08:34:32 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@...com, mingo@...nel.org,
        jiangshanlai@...il.com, dipankar@...ibm.com,
        akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
        josh@...htriplett.org, tglx@...utronix.de, peterz@...radead.org,
        dhowells@...hat.com, edumazet@...gle.com, fweisbec@...il.com,
        oleg@...hat.com, Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH RFC v2 tip/core/rcu 14/22] rcu-tasks: Add an RCU Tasks
 Trace to simplify protection of tracing hooks

On Sat, Mar 28, 2020 at 10:06:35AM -0400, Joel Fernandes wrote:
> On Thu, Mar 19, 2020 at 07:41:53PM -0700, Paul E. McKenney wrote:
> > On Thu, Mar 19, 2020 at 08:48:38PM -0400, Steven Rostedt wrote:
> > > On Thu, 19 Mar 2020 17:28:13 -0700
> > > "Paul E. McKenney" <paulmck@...nel.org> wrote:
> > > 
> > > > Good point.  If interrupts are disabled, it will need to use some
> > > > other mechanism.  One approach is irqwork.  Another is a timer.
> > > > 
> > > > Suggestions?
> > > 
> > > Ftrace and perf use irq_work, I would think that should work here too.
> > 
> > Sounds good, will give it a go!  And thank you for catching this!
> 
> Since the the Tasks-RCU holdout thread is supposed to wake up periodically to
> scan holdout tasks anyway, can it not detect the end of the Trace-RCU grace
> period on its next wake up? Sorry if I missed something.

It could, and that was how it was structured in the first version.
The reason for the timed waits is to be able to print stall warnings.

So here is the (abbreviated) sequence of events:

o	Callbacks appear, waking the kthread.

o	The kthread moves the callbacks to a private list
	and starts the grace period.

o	The kthread scans the tasklist, moving tasks that need
	further processing to the holdout list.  Note that these
	tasks are holding out from being checked, not necessarily
	from being in a quiescent state.

	Note also that tasks that are checked and found to be in
	a read-side critical section are only added to the holdout
	list if their state cannot be modified.

o	The kthreads repeatedly scans the holdout list.  Once a
	task has been successfully checked, it is removed from
	the holdout list.

o	When the holdout list is empty, the kthread stops scanning it.

o	However, the grace period is not necessarily over because some of
	the previously tasks might still be in their read-side critical
	sections.

	So, as noted above, the kthread does timed waits for the
	count of such tasks to go to zero, printing stall warnings
	along the way if it takes too long.

Or am I missing your point?

							Thanx, Paul