linux-kernel - [RFC PATCH v1 25/50] HID: hid-lg: We only need pseudorandom bytes for the address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <202003281643.02SGhG7f004946@sdf.org>
Date:   Wed, 27 Mar 2019 08:27:16 -0400
From:   George Spelvin <lkml@....org>
To:     linux-kernel@...r.kernel.org, lkml@....org
Cc:     Simon Wood <simon@...gewell.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Jiri Kosina <jkosina@...e.cz>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: [RFC PATCH v1 25/50] HID: hid-lg: We only need pseudorandom bytes for
 the address

It's just to reduce collisions among cooperating USB HID
devices; it's not intended to be secure against a malicious
attacker (and it would need to be a lot larger than 16 bits
if it were).

Signed-off-by: George Spelvin <lkml@....org>
Cc: Simon Wood <simon@...gewell.org>
Cc: Hans de Goede <hdegoede@...hat.com>
Cc: Jiri Kosina <jkosina@...e.cz>
Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
---
 drivers/hid/hid-lg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index 0dc7cdfc56f77..b6b6ed9834c7c 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -832,7 +832,7 @@ static int lg_probe(struct hid_device *hdev, const struct hid_device_id *id)
 
 			/* Select random Address */
 			buf[1] = 0xB2;
-			get_random_bytes(&buf[2], 2);
+			prandom_bytes(buf+2, 2);
 
 			ret = hid_hw_raw_request(hdev, buf[0], buf, sizeof(cbuf),
 					HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
-- 
2.26.0