linux-kernel - Re: [PATCH] getdelays: Fix netlink attribute length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200328130341.a23be12b3a0f4cf0288a0d84@linux-foundation.org>
Date:   Sat, 28 Mar 2020 13:03:41 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     David Ahern <dsahern@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Yafang Shao <laoar.shao@...il.com>,
        Johannes Berg <johannes@...solutions.net>,
        Shailabh Nagar <nagar@...son.ibm.com>
Subject: Re: [PATCH] getdelays: Fix netlink attribute length

On Fri, 27 Mar 2020 11:31:11 -0600 David Ahern <dsahern@...nel.org> wrote:

> A recent change to the netlink code:
>   6e237d099fac ("netlink: Relax attr validation for fixed length types")
> logs a warning when programs send messages with invalid attributes
> (e.g., wrong length for a u32). Yafang reported this error message
> for tools/accounting/getdelays.c.
> 
> send_cmd() is wrongly adding 1 to the attribute length. As noted in
> include/uapi/linux/netlink.h nla_len should be NLA_HDRLEN + payload
> length, so drop the +1.

Thanks.

> Fixes: 9e06d3f9f6b1 ("per task delay accounting taskstats interface: documentation fix")
> Signed-off-by: David Ahern <dsahern@...nel.org>
> Tested-by: Yafang Shao <laoar.shao@...il.com>

I'll add Reported-by: as well.

> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: Shailabh Nagar <nagar@...son.ibm.com>

Is this worth a cc:stable?