linux-kernel - Re: [PATCH v2 0/4] RCU dyntick nesting counter cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200328235653.GA69048@google.com>
Date:   Sat, 28 Mar 2020 19:56:53 -0400
From:   Joel Fernandes <joel@...lfernandes.org>
To:     "Paul E. McKenney" <paulmck@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Andy Lutomirski <luto@...nel.org>,
        Frederic Weisbecker <fweisbec@...il.com>, frextrite@...il.com,
        Ingo Molnar <mingo@...hat.com>,
        Josh Triplett <josh@...htriplett.org>, kernel-team@...roid.com,
        Lai Jiangshan <jiangshanlai@...il.com>,
        madhuparnabhowmik04@...il.com,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        peterz@...radead.org, Petr Mladek <pmladek@...e.com>,
        rcu@...r.kernel.org, rostedt@...dmis.org, tglx@...utronix.de,
        vpillai@...italocean.com
Subject: Re: [PATCH v2 0/4] RCU dyntick nesting counter cleanups

On Sat, Mar 28, 2020 at 04:43:06PM -0700, Paul E. McKenney wrote:
> On Sat, Mar 28, 2020 at 06:16:59PM -0400, Joel Fernandes (Google) wrote:
> > These patches clean up the usage of dynticks nesting counters simplifying the
> > code, while preserving the usecases.
> > 
> > It is a much needed simplification, makes the code less confusing, and prevents
> > future bugs such as those that arise from forgetting that the
> > dynticks_nmi_nesting counter is not a simple counter and can be "crowbarred" in
> > common situations.
> > 
> > rcutorture testing with all TREE RCU configurations succeed with
> > CONFIG_RCU_EQS_DEBUG=y and CONFIG_PROVE_LOCKING=y.
> 
> Heh!  We now have a three-way collision between Thomas's and Peter's
> series, the RCU Tasks Trace series, and this series.  ;-)
> 
> Remind me once v5.7-rc1 comes out and let's see what fits where.

Ok, no problem, I will resend at 5.7-rc1 time then. I believe I did a lot of
the work to make the series catch up with the tip especially after the KCSAN
changes, so it should be relatively easy (hopefully) for me to rebase at -rc1.

thanks!

 - Joel



> > v1->v2:
> > - Rebase on v5.6-rc6
> > 
> > Joel Fernandes (Google) (4):
> > Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of
> > ->dynticks counter")
> > rcu/tree: Add better tracing for dyntick-idle
> > rcu/tree: Clean up dynticks counter usage
> > rcu/tree: Remove dynticks_nmi_nesting counter
> > 
> > .../Data-Structures/Data-Structures.rst       |  31 +--
> > Documentation/RCU/stallwarn.txt               |   6 +-
> > include/linux/rcutiny.h                       |   3 -
> > include/trace/events/rcu.h                    |  29 +--
> > kernel/rcu/rcu.h                              |   4 -
> > kernel/rcu/tree.c                             | 188 +++++++-----------
> > kernel/rcu/tree.h                             |   4 +-
> > kernel/rcu/tree_stall.h                       |   4 +-
> > 8 files changed, 105 insertions(+), 164 deletions(-)
> > 
> > --
> > 2.26.0.rc2.310.g2932bb562d-goog
> >