linux-kernel - Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200329102526.1ee85e96@archlinux>
Date:   Sun, 29 Mar 2020 10:25:26 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Guido Günther <agx@...xcpu.org>
Cc:     Tomas Novotny <tomas@...otny.cz>, Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        "Angus Ainslie (Purism)" <angus@...ea.ca>,
        Marco Felsch <m.felsch@...gutronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Nishant Malpani <nish.malpani25@...il.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add
 near-level

On Wed, 25 Mar 2020 12:09:06 +0100
Guido Günther <agx@...xcpu.org> wrote:

> This value indicates when userspace should consider an object
> near to the sensor/device.
> 
> Signed-off-by: Guido Günther <agx@...xcpu.org>

I'm fine with this.  Note for Rob or other DT people.

This is a new generic binding hence no vendor prefix.

I will ideally want review of both the dt patches though
before applying.  As we've missed the merge window anyway
there is no particular rush.

Thanks,

Jonathan

> ---
>  .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml    | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 21ef2eb7a205..ac9e3bb6a505 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -25,6 +25,13 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  near-level:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Raw proximity values equal or above this level should be
> +      considered 'near' to the device (an object is near to the
> +      sensor).
> +
>  required:
>    - compatible
>    - reg
> @@ -40,6 +47,7 @@ examples:
>        light-sensor@51 {
>                compatible = "vishay,vcnl4200";
>                reg = <0x51>;
> +              near-level = <220>;
>        };
>    };
>  ...