linux-kernel - Re: [PATCH] iio: buffer: drop left-over 'stufftoread' field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200329104001.6b62b4ab@archlinux>
Date:   Sun, 29 Mar 2020 10:40:01 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lars@...afoo.de>
Subject: Re: [PATCH] iio: buffer: drop left-over 'stufftoread' field

On Sat, 28 Mar 2020 18:34:21 +0200
Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:

> This seems like a left-over from a7348347ba8a4 ("staging:iio: Add polling
> of events on the ring access chrdev.").
> 
> Then it was moved into the sca3000 driver around 9dd4694dafbd8 ("iio:
> staging: sca3000: hide stufftoread logic"), and that one seemed to be the
> only user of this.
> 
> Then it eventually was no longer used after 152a6a884ae1
> ("staging:iio:accel:sca3000 move to hybrid hard / soft buffer design.")
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
Oops.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  include/linux/iio/buffer_impl.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/iio/buffer_impl.h b/include/linux/iio/buffer_impl.h
> index a4d2d8061ef6..1e7edf6bed96 100644
> --- a/include/linux/iio/buffer_impl.h
> +++ b/include/linux/iio/buffer_impl.h
> @@ -115,9 +115,6 @@ struct iio_buffer {
>  	 */
>  	struct attribute_group scan_el_group;
>  
> -	/* @stufftoread: Flag to indicate new data. */
> -	bool stufftoread;
> -
>  	/* @attrs: Standard attributes of the buffer. */
>  	const struct attribute **attrs;
>