linux-kernel - Re: [PATCH v2 06/14] usb: dwc3: meson-g12a: refactor usb2 phy init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 29 Mar 2020 13:35:04 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Neil Armstrong <narmstrong@...libre.com>
Cc:     kishon@...com, khilman@...libre.com,
        linux-amlogic@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 06/14] usb: dwc3: meson-g12a: refactor usb2 phy init


Hi,

Martin Blumenstingl <martin.blumenstingl@...glemail.com> writes:

> Hi Neil,
>
> On Thu, Mar 26, 2020 at 2:45 PM Neil Armstrong <narmstrong@...libre.com> wrote:
>>
>> Refactor the USB2 PHY init code patch to handle the Amlogic GXL/GXM
>> not having the PHY mode control registers in the Glue but in the PHY
>> registers.
>>
>> The Amlogic GXL/GXM will call phy_set_mode() instead of programming the
>> PHY mode control registers, thus add two new callbacks to the SoC match
>> data.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> checkpatch reports that five lines need to be checked.
> these all look valid (for example: "Alignment should match open parenthesis")
>
> with these addressed:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

That's a CHECK, only shows with --strict. drivers/usb/ ignores those for
the most part.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)