linux-kernel - RE: [EXT] Re: [net-next,v1] net: mscc: ocelot: add action of police on vcap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB8PR04MB64264BF8BDFA26590409F40EF0CA0@DB8PR04MB6426.eurprd04.prod.outlook.com>
Date:   Sun, 29 Mar 2020 01:41:07 +0000
From:   Xiaoliang Yang <xiaoliang.yang_1@....com>
To:     Vladimir Oltean <olteanv@...il.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Andrew Lunn <andrew@...n.ch>,
        "Allan W. Nielsen" <allan.nielsen@...rochip.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        "Y.b. Lu" <yangbo.lu@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Po Liu <po.liu@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Leo Li <leoyang.li@....com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: RE: [EXT] Re: [net-next,v1] net: mscc: ocelot: add action of police
 on vcap_is2

Hi Vladimir,

Thanks, you are right, the patch need to change rule->pol to tmp->pol. I have seen your patch series, it's better to add this patch to your patch series.

Regards,
Xiaoliang Yang

-----Original Message-----
From: Vladimir Oltean <olteanv@...il.com> 
Sent: 2020年3月29日 8:55
To: Xiaoliang Yang <xiaoliang.yang_1@....com>
Cc: David S. Miller <davem@...emloft.net>; netdev <netdev@...r.kernel.org>; lkml <linux-kernel@...r.kernel.org>; Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>; Horatiu Vultur <horatiu.vultur@...rochip.com>; Alexandre Belloni <alexandre.belloni@...tlin.com>; Andrew Lunn <andrew@...n.ch>; Allan W. Nielsen <allan.nielsen@...rochip.com>; Vivien Didelot <vivien.didelot@...il.com>; Joergen Andreasen <joergen.andreasen@...rochip.com>; Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>; Y.b. Lu <yangbo.lu@....com>; Alexandru Marginean <alexandru.marginean@....com>; Po Liu <po.liu@....com>; Claudiu Manoil <claudiu.manoil@....com>; Vladimir Oltean <vladimir.oltean@....com>; Leo Li <leoyang.li@....com>; Florian Fainelli <f.fainelli@...il.com>
Subject: [EXT] Re: [net-next,v1] net: mscc: ocelot: add action of police on vcap_is2

Caution: EXT Email

On Sat, 28 Mar 2020 at 15:50, Vladimir Oltean <olteanv@...il.com> wrote:
>
> Hi Xiaoliang,
>
> Thanks for the patch. I've tested it, but sadly, as-is it doesn't compile.
> But then again, net-next doesn't compile either, so there...
>
> On Sat, 28 Mar 2020 at 14:41, Xiaoliang Yang <xiaoliang.yang_1@....com> wrote:
> >
> > Ocelot has 384 policers that can be allocated to ingress ports, QoS 
> > classes per port, and VCAP IS2 entries. ocelot_police.c supports to 
> > set policers which can be allocated to police action of VCAP IS2. We 
> > allocate policers from maximum pol_id, and decrease the pol_id when 
> > add a new vcap_is2 entry which is police action.
> >
> > Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@....com>
> > ---
[snip]
>
> For what it's worth, I am preparing another patch series for port 
> policers in DSA, and I'm keeping your patch in my tree and rebasing on 
> top of it. Depending on how things go with review, do you mind if I 
> just take your patch to address other received feedback, and repost 
> your flow-based policers together with my port-based policers?
>
> Regards,
> -Vladimir

I took the liberty to repost your patch with the compilation error fixed, as part of this series:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F1263358%2F&amp;data=02%7C01%7Cxiaoliang.yang_1%40nxp.com%7Cb9d56ee5885d4eb41ef708d7d37bce6b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637210401032321171&amp;sdata=aXfztjxAHg0JJwieZQSmSNe5tYftJyVYS5MMy66awUU%3D&amp;reserved=0

So this patch is now superseded.

Thanks,
-Vladimir