linux-kernel - Re: [PATCH v2 1/2] mm/memory_hotplug: simplify calculation of number of pages in __remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjEk_smqiRh4-JosHsRxzhedJddGf5EQV0JxqZtHYMdkA@mail.gmail.com>
Date:   Sun, 29 Mar 2020 13:09:36 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     David Hildenbrand <david@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>,
        Segher Boessenkool <segher@...nel.crashing.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Oscar Salvador <osalvador@...e.de>,
        Michal Hocko <mhocko@...nel.org>, Baoquan He <bhe@...hat.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Wei Yang <richardw.yang@...ux.intel.com>
Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: simplify calculation of number
 of pages in __remove_pages()

On Sun, Mar 29, 2020 at 12:19 PM David Hildenbrand <david@...hat.com> wrote:
>
> This patch seems to have another of these weird MIME crap in it. (my
> other patches in -next seem to be fine)
>
> See
>
> https://lore.kernel.org/linux-mm/20200228095819.10750-2-david@redhat.com/raw

That email actually looks fine.

Yes, it has that

   fro=
   m

pattern, but it also has

   Content-Transfer-Encoding: quoted-printable

so the recipient should be doing the right thing with that pattern.

The patch itself also has MIME encoding in it:

   - cur_nr_pages =3D min(end_pfn - pfn, -(pfn | PAGE_SECTION_MASK));
   + cur_nr_pages =3D min(end_pfn - pfn,

so the patch wouldn't even apply unless the recipient did the proper
MIME decode of the message.

That's also why the non-raw message looks fine:

  https://lore.kernel.org/linux-mm/20200228095819.10750-2-david@redhat.com/

because the raw message data has the proper encoding information.

In contrast, look at the email that Andrew sent me and that I complained about:

   https://lore.kernel.org/linux-mm/20200329021719.MBKzW0xSl%25akpm@linux-foundation.org/

and notice how that *non-raw* email has that

   Withou=
   t

pattern in it. And when you look at the raw one:

  https://lore.kernel.org/linux-mm/20200329021719.MBKzW0xSl%25akpm@linux-foundation.org/raw

it has no content transfer encoding line in the headers.

                 Linus