linux-kernel - Re: [PATCH -next] dmaengine: hisilicon: Fix build error without PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5E815BDD.8050908@hisilicon.com>
Date:   Mon, 30 Mar 2020 10:39:25 +0800
From:   Zhou Wang <wangzhou1@...ilicon.com>
To:     YueHaibing <yuehaibing@...wei.com>, <dan.j.williams@...el.com>,
        <vkoul@...nel.org>, <qiuzhenfa@...ilicon.com>
CC:     <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] dmaengine: hisilicon: Fix build error without
 PCI_MSI

On 2020/3/28 19:41, YueHaibing wrote:
> If PCI_MSI is not set, building fais:
> 
> drivers/dma/hisi_dma.c: In function ‘hisi_dma_free_irq_vectors’:
> drivers/dma/hisi_dma.c:138:2: error: implicit declaration of function ‘pci_free_irq_vectors’;
>  did you mean ‘pci_alloc_irq_vectors’? [-Werror=implicit-function-declaration]
>   pci_free_irq_vectors(data);
>   ^~~~~~~~~~~~~~~~~~~~
>
> Make HISI_DMA depends on PCI_MSI to fix this.

In ARM64, it will appear this compile error if PCI disables.
How about adding depends on PCI && PCI_MSI here?

Best,
Zhou

> 
> Fixes: e9f08b65250d ("dmaengine: hisilicon: Add Kunpeng DMA engine support")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/dma/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 092483644315..023db6883d05 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -241,7 +241,8 @@ config FSL_RAID
>  
>  config HISI_DMA
>  	tristate "HiSilicon DMA Engine support"
> -	depends on ARM64 || (COMPILE_TEST && PCI_MSI)
> +	depends on ARM64 || COMPILE_TEST
> +	depends on PCI_MSI
>  	select DMA_ENGINE
>  	select DMA_VIRTUAL_CHANNELS
>  	help
>