linux-kernel - Re: [PATCH 00/15] AMD ntb driver fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPoiz9zBxB28nfCudr0xXYi4Lg7XRJXshTLvTM5W5uMcvw=2FQ@mail.gmail.com>
Date:   Mon, 30 Mar 2020 17:09:08 -0400
From:   Jon Mason <jdmason@...zu.us>
To:     "Nath, Arindam" <Arindam.Nath@....com>
Cc:     "Mehta, Sanju" <Sanju.Mehta@....com>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>,
        Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <allenbh@...il.com>,
        Jiasen Lin <linjiasen@...on.cn>,
        "linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/15] AMD ntb driver fixes and improvements

On Mon, Mar 30, 2020 at 2:43 PM Nath, Arindam <Arindam.Nath@....com> wrote:
>
> > -----Original Message-----
> > From: Jon Mason <jdmason@...zu.us>
> > Sent: Friday, March 13, 2020 05:55
> > To: Mehta, Sanju <Sanju.Mehta@....com>
> > Cc: Nath, Arindam <Arindam.Nath@....com>; S-k, Shyam-sundar <Shyam-
> > sundar.S-k@....com>; Dave Jiang <dave.jiang@...el.com>; Allen Hubbe
> > <allenbh@...il.com>; Jiasen Lin <linjiasen@...on.cn>; Mehta, Sanju
> > <Sanju.Mehta@....com>; linux-ntb@...glegroups.com; linux-
> > kernel@...r.kernel.org
> > Subject: Re: [PATCH 00/15] AMD ntb driver fixes and improvements
> >
> > On Fri, Feb 07, 2020 at 04:28:53PM +0530, Sanjay R Mehta wrote:
> > >
> > >
> > > On 2/5/2020 9:24 PM, Arindam Nath wrote:
> > > > [CAUTION: External Email]
> > > >
> > > > This patch series fixes some bugs in the existing
> > > > AMD NTB driver, cleans-up code, and modifies the
> > > > code to handle NTB link-up/down events. The series
> > > > is based on Linus' tree,
> > > >
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > >
> > > > Arindam Nath (15):
> > > >   NTB: Fix access to link status and control register
> > > >   NTB: clear interrupt status register
> > > >   NTB: Enable link up and down event notification
> > > >   NTB: define a new function to get link status
> > > >   NTB: return the side info status from amd_poll_link
> > > >   NTB: set peer_sta within event handler itself
> > > >   NTB: remove handling of peer_sta from amd_link_is_up
> > > >   NTB: handle link down event correctly
> > > >   NTB: handle link up, D0 and D3 events correctly
> > > >   NTB: move ntb_ctrl handling to init and deinit
> > > >   NTB: add helper functions to set and clear sideinfo
> > > >   NTB: return link up status correctly for PRI and SEC
> > > >   NTB: remove redundant setting of DB valid mask
> > > >   NTB: send DB event when driver is loaded or un-loaded
> > > >   NTB: add pci shutdown handler for AMD NTB
> > >
> > > The patch series looks good to me. Thanks for the changes.
> > >
> > > For all the ntb_hw_amd changes:
> > >
> > > Reviewed-by: Sanjay R Mehta <sanju.mehta@....com>
> >
> > I had to rework the first patch, since Jiasen's patch was already in
> > my tree for a couple months.  The rest applied fine and will be in my
> > git trees on github in a couple of hours (sanity build pending).
> >
>
> Hi Jon,
>
> Just wanted to know whether the changes are in your tree now?

You should see them in my ntb branch and I'll be sending out a pull req


>
> Thanks,
> Arindam
>
> > Thanks,
> > Jon
> >
> > >
> > >
> > > >
> > > >  drivers/ntb/hw/amd/ntb_hw_amd.c | 290
> > ++++++++++++++++++++++++++------
> > > >  drivers/ntb/hw/amd/ntb_hw_amd.h |   8 +-
> > > >  2 files changed, 247 insertions(+), 51 deletions(-)
> > > >
> > > > --
> > > > 2.17.1
> > > >