lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87lfnhifad.wl-kuninori.morimoto.gx@renesas.com>
Date:   31 Mar 2020 08:39:06 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ASoC: dt-bindings: simple-card: switch to yaml base Documentation


Hi

> > From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> > 
> > This patch switches from .txt base to .yaml base Document.
> > This patch is assuming that "sound-dai" is already defined.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> > ---
(snip)
> > +  clocks:
> > +    maxItems: 1
> 
> Only used in one place, just move there.

OK, will fix

> > +# use patternProperties to use "#definitions/xxx"
> 
> Huh? The meta-schema gives you an error? We should fix that, not 
> work-around it.
> 
> > +patternProperties:
> > +  "^simple-audio-card,widgets$":
> > +    $ref: "#/definitions/widgets"
> > +  "^simple-audio-card,routing$":
> > +    $ref: "#/definitions/routing"
> > +  "^simple-audio-card,cpu(@[0-9a-f]+)?":
> > +    $ref: "#/definitions/dai"
> > +  "^simple-audio-card,codec(@[0-9a-f]+)?":
> > +    $ref: "#/definitions/dai"

Oops, strange comment.

	-# use patternProperties to use "#definitions/xxx"
	+# use patternProperties to use "xxx,xxx"


Thank you for your help !!

Best regards
---
Kuninori Morimoto

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ