linux-kernel - Re: [PATCH v9 13/55] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <278eb2ef-dc55-99dc-5525-f0eccea508f6@mentor.com>
Date:   Mon, 30 Mar 2020 13:10:41 +0900
From:   "Wang, Jiada" <jiada_wang@...tor.com>
To:     Dmitry Osipenko <digetx@...il.com>, <nick@...anahar.org>,
        <dmitry.torokhov@...il.com>, <jikos@...nel.org>,
        <benjamin.tissoires@...hat.com>, <bsz@...ihalf.com>,
        <rydberg@...math.org>
CC:     <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <erosca@...adit-jv.com>, <Andrew_Gabbasov@...tor.com>
Subject: Re: [PATCH v9 13/55] Input: atmel_mxt_ts - add regulator control
 support

Hi Dmitry

On 2020/03/30 3:54, Dmitry Osipenko wrote:
> 27.03.2020 14:09, Wang, Jiada пишет:
>> Hi Dmitry
>>
>> On 2020/03/26 4:05, Dmitry Osipenko wrote:
>>> 25.03.2020 16:32, Jiada Wang пишет:
>>>> From: Nick Dyer <nick.dyer@...ev.co.uk>
>>>>
>>>> Allow the driver to optionally manage enabling/disable power to the
>>>> touch
>>>> controller itself. If the regulators are not present then use the deep
>>>> sleep power mode instead.
>>>>
>>>> For a correct power on sequence, it is required that we have control
>>>> over
>>>> the RESET line.
>>>
>>> ...
>>>> +    data->reg_vdd = devm_regulator_get(dev, "vdd");
>>>> +    if (IS_ERR(data->reg_vdd)) {
>>>> +        error = PTR_ERR(data->reg_vdd);
>>>> +        dev_err(dev, "Error %d getting vdd regulator\n", error);
>>>> +        goto fail;
>>>> +    }
>>>> +
>>>> +    data->reg_avdd = devm_regulator_get(dev, "avdd");
>>>> +    if (IS_ERR(data->reg_avdd)) {
>>>> +        error = PTR_ERR(data->reg_avdd);
>>>> +        dev_err(dev, "Error %d getting avdd regulator\n", error);
>>>> +        goto fail_release;
>>>> +    }
>>>
>>> Hello Jiada,
>>>
>>> The new regulator properties should be documented in the device-tree
>>> binding.
>>>
>> I will document new regulator properties in a separate commit in
>> v10 patch-set
> 
> Please make sure that all patches are added in a correct order and that
> they at least compile. This patch doesn't compile:
> 
Sure, I will take care of this issue in next version

Thanks,
Jiada
>    CC      drivers/input/touchscreen/atmel_mxt_ts.o
> drivers/input/touchscreen/atmel_mxt_ts.c:34:10: fatal error:
> dt-bindings/input/atmel_mxt_ts.h: No such file or directory
>     34 | #include <dt-bindings/input/atmel_mxt_ts.h>
>