linux-kernel - Re: [PATCH] loop: Add LOOP_SET_FD_WITH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB0TPYG4N-2Gg95VwQuQBQ8rvjC=4NQJP4syJWS3Q6CO28HzTQ@mail.gmail.com>
Date:   Mon, 30 Mar 2020 10:06:41 +0200
From:   Martijn Coenen <maco@...roid.com>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
        Bart Van Assche <bvanassche@....org>,
        Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>,
        linux-block <linux-block@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@...roid.com
Subject: Re: [PATCH] loop: Add LOOP_SET_FD_WITH_OFFSET ioctl.

Hi Ming,

On Mon, Mar 30, 2020 at 3:00 AM Ming Lei <ming.lei@...hat.com> wrote:
> The new ioctl LOOP_SET_FD_WITH_OFFSET looks not generic enough, could
> you consider to add one ioctl LOOP_SET_FD_AND_STATUS to cover both
> SET_FD and SET_STATUS so that using two ioctl() to setup loop can become
> deprecated finally?

I originally started out doing that. However, it is a significantly
larger refactoring of the loop driver, and it makes things like error
handling more complex. I thought configuring loop with an offset is
the most common case. But if there's a preference to do an ioctl that
takes the full status, I can work on that.

Best,
Martijn

>
>
> Thanks,
> Ming
>