linux-kernel - Re: rtc: fsl-ftm-alarm: add shutdown interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Mar 2020 18:44:00 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Biwen Li <biwen.li@....nxp.com>
Cc:     leoyang.li@....com, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, jiafei.pan@....com,
        Biwen Li <biwen.li@....com>
Subject: Re: rtc: fsl-ftm-alarm: add shutdown interface

On 30/03/2020 20:26:16+0800, Biwen Li wrote:
> From: Biwen Li <biwen.li@....com>
> 
> Add shutdown interface
> 
> Signed-off-by: Biwen Li <biwen.li@....com>
> ---
>  drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
> index d7fa6c16f47b..118a775e8316 100644
> --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> @@ -307,6 +307,15 @@ static int ftm_rtc_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static void ftm_rtc_shutdown(struct platform_device *pdev)
> +{
> +	struct ftm_rtc *rtc = platform_get_drvdata(pdev);
> +
> +	ftm_irq_acknowledge(rtc);
> +	ftm_irq_disable(rtc);
> +	ftm_clean_alarm(rtc);

If the alarm is able to start the platform, then you probably don't want
to disable the alarm on shutdown.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com