linux-kernel - Re: [PATCH v7 3/3] thermal: tegra: add get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <156ef39f-4bb2-c7fb-7bf0-abc9e0067c62@linaro.org>
Date:   Mon, 30 Mar 2020 19:23:14 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Wei Ni <wni@...dia.com>, edubezval@...il.com
Cc:     thierry.reding@...il.com, linux-tegra@...r.kernel.org,
        rui.zhang@...el.com, srikars@...dia.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v7 3/3] thermal: tegra: add get_trend ops

Hi Wei,

On 19/02/2019 03:15, Wei Ni wrote:

>>> +static int tegra_thermctl_get_trend(void *data, int trip, +
>>> enum thermal_trend *trend)

[ ... ]

>>> +	temp = tz->temperature; +	last_temp = tz->last_temperature; +
>>> mutex_unlock(&tz->lock); + +	if (temp > trip_temp) { +		if
>>> (temp >= last_temp) +			*trend = THERMAL_TREND_RAISING; +
>>> else +			*trend = THERMAL_TREND_STABLE; +	} else if (temp <
>>> trip_temp) { +		*trend = THERMAL_TREND_DROPPING; +	} else { +
>>> *trend = THERMAL_TREND_STABLE; +	} + +	return 0; +} + static
>>> const struct thermal_zone_of_device_ops tegra_of_thermal_ops =
>>> { .get_temp = tegra_thermctl_get_temp, .set_trip_temp =
>>> tegra_thermctl_set_trip_temp, +	.get_trend =
>>> tegra_thermctl_get_trend, };

It has been awhile since this patch was submitted and merged by
Eduardo. I replace him to co-maintain the thermal framework with Rui.

While figuring out the internals for code cleanup, I ended up in this
function above.

Why do you have to use this routine instead of the generic one in
get_tz_trend()?



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog