linux-kernel - RE: [PATCH -next] ACPICA: Make acpi_protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR11MB171942777865293C74EF1D9AF0CB0@CY4PR11MB1719.namprd11.prod.outlook.com>
Date:   Mon, 30 Mar 2020 17:52:23 +0000
From:   "Kaneda, Erik" <erik.kaneda@...el.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        YueHaibing <yuehaibing@...wei.com>,
        "Moore, Robert" <robert.moore@...el.com>
CC:     "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] ACPICA: Make acpi_protocol_lengths static



> -----Original Message-----
> From: linux-acpi-owner@...r.kernel.org <linux-acpi-
> owner@...r.kernel.org> On Behalf Of Rafael J. Wysocki
> Sent: Saturday, March 28, 2020 2:14 AM
> To: YueHaibing <yuehaibing@...wei.com>; Moore, Robert
> <robert.moore@...el.com>; Kaneda, Erik <erik.kaneda@...el.com>
> Cc: Wysocki, Rafael J <rafael.j.wysocki@...el.com>; Len Brown
> <lenb@...nel.org>; ACPI Devel Maling List <linux-acpi@...r.kernel.org>;
> open list:ACPI COMPONENT ARCHITECTURE (ACPICA) <devel@...ica.org>;
> Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH -next] ACPICA: Make acpi_protocol_lengths static
> 
> On Sat, Mar 28, 2020 at 4:47 AM YueHaibing <yuehaibing@...wei.com>
> wrote:
> >
> > Fix sparse warning:
> >
> > drivers/acpi/acpica/exfield.c:25:10: warning:
> >  symbol 'acpi_protocol_lengths' was not declared. Should it be static?
 
I don’t understand what sparse is trying to say here. This variable is declared in exfield.c...
Could you provide more details on this sparse warning?

Erik

> >
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Bob, Erik, I'm leaving this one to you.
> 
> > ---
> >  drivers/acpi/acpica/exfield.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/acpica/exfield.c
> > b/drivers/acpi/acpica/exfield.c index e85eb31e5075..3323a2ba6a31
> > 100644
> > --- a/drivers/acpi/acpica/exfield.c
> > +++ b/drivers/acpi/acpica/exfield.c
> > @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
> >   */
> >  #define ACPI_INVALID_PROTOCOL_ID        0x80
> >  #define ACPI_MAX_PROTOCOL_ID            0x0F
> > -const u8 acpi_protocol_lengths[] = {
> > +static const u8 acpi_protocol_lengths[] = {
> >         ACPI_INVALID_PROTOCOL_ID,       /* 0 - reserved */
> >         ACPI_INVALID_PROTOCOL_ID,       /* 1 - reserved */
> >         0x00,                   /* 2 - ATTRIB_QUICK */
> > --
> > 2.17.1
> >
> >