linux-kernel - Re: [PATCH v3] rtc: ds1307: add support for watchdog timer on ds1388

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200330183917.GG846876@piout.net>
Date:   Mon, 30 Mar 2020 20:39:17 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     a.zummo@...ertech.it, wim@...ux-watchdog.org, linux@...ck-us.net,
        linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] rtc: ds1307: add support for watchdog timer on ds1388

On 30/03/2020 15:55:00+1300, Chris Packham wrote:
> The DS1388 variant has watchdog timer capabilities. When using a DS1388
> and having enabled CONFIG_WATCHDOG_CORE register a watchdog device for
> the DS1388.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
> Changes in v3:
> - Address review comments from Guenter. Add select WATCHDOG_CORE, remove
>   unnecessary wdt member, add set_timeout op, use devm_watchdog_register
> Changes in v2:
> - Address review comments from Alexandre, the only functional change is setting
>   the hundredths of seconds to 0 instead of 99.
> 
>  drivers/rtc/Kconfig      |   1 +
>  drivers/rtc/rtc-ds1307.c | 115 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 116 insertions(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com