linux-kernel - Re: [PATCH v2 net-next 0/6] Port and flow policers for DSA (SJA1105, Felix/Ocelot)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Mar 2020 11:44:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        jiri@...nulli.us, idosch@...sch.org, kuba@...nel.org,
        netdev@...r.kernel.org, xiaoliang.yang_1@....com,
        linux-kernel@...r.kernel.org, horatiu.vultur@...rochip.com,
        alexandre.belloni@...tlin.com, allan.nielsen@...rochip.com,
        joergen.andreasen@...rochip.com, UNGLinuxDriver@...rochip.com,
        yangbo.lu@....com, alexandru.marginean@....com, po.liu@....com,
        claudiu.manoil@....com, leoyang.li@....com,
        nikolay@...ulusnetworks.com, roopa@...ulusnetworks.com
Subject: Re: [PATCH v2 net-next 0/6] Port and flow policers for DSA
 (SJA1105, Felix/Ocelot)

From: Vladimir Oltean <olteanv@...il.com>
Date: Sun, 29 Mar 2020 14:51:56 +0300

> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> This series adds support for 2 types of policers:
>  - port policers, via tc matchall filter
>  - flow policers, via tc flower filter
> for 2 DSA drivers:
>  - sja1105
>  - felix/ocelot
> 
> First we start with ocelot/felix. Prior to this patch, the ocelot core
> library currently only supported:
> - Port policers
> - Flow-based dropping and trapping
> But the felix wrapper could not actually use the port policers due to
> missing linkage and support in the DSA core. So one of the patches
> addresses exactly that limitation by adding the missing support to the
> DSA core. The other patch for felix flow policers (via the VCAP IS2
> engine) is actually in the ocelot library itself, since the linkage with
> the ocelot flower classifier has already been done in an earlier patch
> set.
> 
> Then with the newly added .port_policer_add and .port_policer_del, we
> can also start supporting the L2 policers on sja1105.
> 
> Then, for full functionality of these L2 policers on sja1105, we also
> implement a more limited set of flow-based policing keys for this
> switch, namely for broadcast and VLAN PCP.
> 
> Series version 1 was submitted here:
> https://patchwork.ozlabs.org/cover/1263353/
> 
> Nothing functional changed in v2, only a rebase.

This looks fine to me, series applied, thanks.