linux-kernel - Re: [PATCH 02/39] MIPS: loongson64: Add header files path prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1712ea7ba9a.dad1f80a33831.4741900511750683483@flygoat.com>
Date:   Tue, 31 Mar 2020 11:34:36 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     "maobibo" <maobibo@...ngson.cn>
Cc:     "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "Huacai Chen" <chenhc@...ote.com>,
        "linux-mips" <linux-mips@...r.kernel.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/39] MIPS: loongson64: Add header files path prefix



--
Jiaxun Yang

 ---- 在 星期一, 2020-03-30 18:00:19 maobibo <maobibo@...ngson.cn> 撰写 ----
 > 
 > 
 > On 03/30/2020 04:55 PM, Jiaxun Yang wrote:
 > > 
 > > 
 > > 于 2020年3月30日 GMT+08:00 下午4:38:51, bibo mao <maobibo@...ngson.cn> 写到:
 > >> Remove header files from arch/mips/include/asm/mach-loongson64
 > >> to arch/mips/loongson64/include/mach
 > >>
 > >> Signed-off-by: bibo mao <maobibo@...ngson.cn>
 > > 
 > > Hi Bibo,
 > > 
 > > Thanks for your patch.
 > > 
 > > What's your intention?
 > > Did you meet any problem about headers?
 > > 
 > 
 > Hi Jiaxun,
 > 
 > When I add irqchip support for mips kvm, file virt/kvm/irqchip.c
 > requires local header file arch/mips/kvm/irq.h, it fails to compile.
 > Since there is file with the same name located at:
 >   arch/mips/include/asm/mach-generic/irq.h
 >   arch/mips/include/asm/mach-loongson64/irq.h
 > 
 > The compiler fails to choose the correct header file irq.h,

You'd better rename kvm's irq.h in this case.

 > 
 > regards
 > bibo,mao
 > 
 > >> ---
 > >> arch/mips/Kconfig                                                 | 1 +
 > >> arch/mips/loongson64/Platform                                     | 2
 > >> +-
 > >> arch/mips/loongson64/env.c                                        | 8
 > >> ++++----