linux-kernel - Re: [Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Mar 2020 17:50:10 +0300
From:   Oleksandr Andrushchenko <andr2000@...il.com>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>,
        oleksandr_andrushchenko@...m.com, airlied@...ux.ie, daniel@...ll.ch
Cc:     xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR_ERR'
 warning

On 3/30/20 12:59, Ding Xiang wrote:
> Fix a static code checker warning:
>      drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
>      warn: passing zero to 'PTR_ERR'
>
> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
> ---
>   drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 4be49c1..3741420 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>   
>   	obj = xen_drm_front_gem_create(dev, args->size);
>   	if (IS_ERR_OR_NULL(obj)) {
> -		ret = PTR_ERR(obj);
> +		ret = PTR_ERR_OR_ZERO(obj);
>   		goto fail;
>   	}
>