[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BN6PR03MB334776C7AD6C7C2B2F4A55A399C80@BN6PR03MB3347.namprd03.prod.outlook.com>
Date: Tue, 31 Mar 2020 15:30:46 +0000
From: "Sa, Nuno" <Nuno.Sa@...log.com>
To: Rohit Sarkar <rohitsarkar5398@...il.com>,
Lars-Peter Clausen <lars@...afoo.de>
CC: "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>,
"jic23@...nel.org" <jic23@...nel.org>,
"zhongjiang@...wei.com" <zhongjiang@...wei.com>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"Bogdan, Dragos" <Dragos.Bogdan@...log.com>,
"pmeerw@...erw.net" <pmeerw@...erw.net>,
"knaack.h@....de" <knaack.h@....de>,
"Hennerich, Michael" <Michael.Hennerich@...log.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/2] use DEFINE_DEBUGFS_ATTRIBUTE instead of
DEFINE_SIMPLE_ATTRIBUTE
> From: Rohit Sarkar <rohitsarkar5398@...il.com>
> Sent: Dienstag, 31. März 2020 13:50
> To: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Sa, Nuno <Nuno.Sa@...log.com>; Ardelean, Alexandru
> <alexandru.Ardelean@...log.com>; jic23@...nel.org;
> stefan.popa@...log.com; zhongjiang@...wei.com; linux-
> iio@...r.kernel.org; Bogdan, Dragos <Dragos.Bogdan@...log.com>;
> pmeerw@...erw.net; knaack.h@....de; Hennerich, Michael
> <Michael.Hennerich@...log.com>; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 0/2] use DEFINE_DEBUGFS_ATTRIBUTE instead of
> DEFINE_SIMPLE_ATTRIBUTE
>
> Hey Nuno,
> > > > >
> > > > I don't have the exact parts that this patch is touching but I have other
> parts where this patch
> > > > applies and should be same. So, the idea to test this is to read the files in
> debugfs? Maybe also
> > > > some unbind + binding?
> > > >
> > > > I will try to test this still today...
> > >
> > > The stress test is to open the debugfs file, then unbind the device and then
> > > read from the still open debugfs file.
> > Yes, also just to be sure, we need to test DEFINE_DEBUGFS_ATTRIBUTE
> > along with debugfs_create_file_unsafe. I will send out another patch
> > that changes debugfs_create_file to debugfs_create_file_unsafe and then
> > that can be tested.
> Have sent out a v2 that is ready to be tested
So I tested your changes in a different HW but the principle is the same.
It worked as expected. Unbinding the device and doing a read on an opened file
descriptor afterwards returns error...
- Nuno Sá
> > > - Lars
> >
> > Thanks,
> > Rohit
> Thanks,
> Rohit
Powered by blists - more mailing lists