linux-kernel - RE: [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB58B6CABF0F@fmsmsx101.amr.corp.intel.com>
Date:   Tue, 31 Mar 2020 16:59:02 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] netdevsim: dev: Fix memory leak in
 nsim_dev_take_snapshot_write



> -----Original Message-----
> From: Gustavo A. R. Silva <gustavo@...eddedor.com>
> Sent: Monday, March 30, 2020 4:27 PM
> To: Jakub Kicinski <kuba@...nel.org>; David S. Miller <davem@...emloft.net>;
> Keller, Jacob E <jacob.e.keller@...el.com>; Jiri Pirko <jiri@...lanox.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Gustavo A. R. Silva
> <gustavo@...eddedor.com>
> Subject: [PATCH net-next] netdevsim: dev: Fix memory leak in
> nsim_dev_take_snapshot_write
> 
> In case memory resources for dummy_data were allocated, release them
> before return.
> 
> Addresses-Coverity-ID: 1491997 ("Resource leak")
> Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have
> been used")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---

Ahh! Thanks!

Belated Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>