[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200331174021.GA4288@bogus>
Date: Tue, 31 Mar 2020 11:40:21 -0600
From: Rob Herring <robh@...nel.org>
To: Baolin Wang <baolin.wang7@...il.com>
Cc: mark.rutland@....com, jassisinghbrar@...il.com,
orsonzhai@...il.com, zhang.lyra@...il.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mailbox: Add the Spreadtrum mailbox
documentation
On Mon, Mar 23, 2020 at 02:13:46PM +0800, Baolin Wang wrote:
> From: Baolin Wang <baolin.wang@...soc.com>
>
> Add the Spreadtrum mailbox documentation.
>
> Signed-off-by: Baolin Wang <baolin.wang@...soc.com>
> Signed-off-by: Baolin Wang <baolin.wang7@...il.com>
> ---
> Changes from v1:
> - Add 'additionalProperties'.
> - Split description for each entry.
> ---
> .../devicetree/bindings/mailbox/sprd-mailbox.yaml | 62 ++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
>
> diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> new file mode 100644
> index 0000000..0848b18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Spreadtrum mailbox controller bindings
> +
> +maintainers:
> + - Orson Zhai <orsonzhai@...il.com>
> + - Baolin Wang <baolin.wang7@...il.com>
> + - Chunyan Zhang <zhang.lyra@...il.com>
> +
> +properties:
> + compatible:
> + enum:
> + - sprd,sc9860-mailbox
> +
> + reg:
> + items:
> + - description: inbox registers' base address
> + - description: outbox registers' base address
> + minItems: 2
This is redundant, drop it.
> +
> + interrupts:
> + items:
> + - description: inbox interrupt
> + - description: outbox interrupt
> + minItems: 2
Same here.
With that,
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists